Issue 894323003: Wait for analysis in search domain. Rewrite with async/await.

Issue 894323003: Wait for analysis in search domain. Rewrite with async/await. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Wait for analysis in search domain. Rewrite with async/await. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43435

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+787 lines, -937 lines)			Patch
M	pkg/analysis_server/lib/src/search/search_domain.dart	View	6 chunks	+66 lines, -58 lines	2 comments	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	4 chunks	+9 lines, -92 lines	0 comments	Download
M	pkg/analysis_server/test/search/abstract_search_domain.dart	View	2 chunks	+21 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/search/element_references_test.dart	View	29 chunks	+247 lines, -276 lines	0 comments	Download
M	pkg/analysis_server/test/search/member_declarations_test.dart	View	9 chunks	+40 lines, -57 lines	0 comments	Download
M	pkg/analysis_server/test/search/member_references_test.dart	View	4 chunks	+28 lines, -34 lines	0 comments	Download
M	pkg/analysis_server/test/search/top_level_declarations_test.dart	View	3 chunks	+16 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/test/search/type_hierarchy_test.dart	View	12 chunks	+360 lines, -395 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/894323003/diff/1/pkg/analysis_server/lib/src/search/search_domain.dart File pkg/analysis_server/lib/src/search/search_domain.dart (right): https://codereview.chromium.org/894323003/diff/1/pkg/analysis_server/lib/src/search/search_domain.dart#newcode47 pkg/analysis_server/lib/src/search/search_domain.dart:47: await server.onAnalysisComplete; Do we also need to wait ...

5 years, 10 months ago (2015-02-03 21:49:20 UTC) #2

scheglov

https://codereview.chromium.org/894323003/diff/1/pkg/analysis_server/lib/src/search/search_domain.dart File pkg/analysis_server/lib/src/search/search_domain.dart (right): https://codereview.chromium.org/894323003/diff/1/pkg/analysis_server/lib/src/search/search_domain.dart#newcode47 pkg/analysis_server/lib/src/search/search_domain.dart:47: await server.onAnalysisComplete; On 2015/02/03 21:49:20, Brian Wilkerson wrote: > ...

5 years, 10 months ago (2015-02-03 21:51:19 UTC) #3

scheglov

5 years, 10 months ago (2015-02-03 21:59:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43435 (presubmit successful).

Expand Messages | Collapse Messages