Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 894063004: Fix return type checking for generator functions. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix return type checking for generator functions. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -10 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +11 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 3 chunks +51 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-03 01:05:15 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-03 03:49:10 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-03 15:43:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698