Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 893563002: Mark co19 firstMatch_A01_t01 as incorrect. (Closed)

Created:
5 years, 10 months ago by zerny-google
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark co19 firstMatch_A01_t01 as incorrect. Also update the issue of the remaining NonEmptyClassRanges tests to issue 22200. BUG=http://dartbug.com/22200, https://code.google.com/p/co19/issues/detail?id=742 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=43335

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/Co/co #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -40 lines) Patch
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-co19.status View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/co19/co19-dart2js.status View 9 chunks +24 lines, -26 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/893563002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/893563002/diff/1/tests/co19/co19-co19.status#newcode55 tests/co19/co19-co19.status:55: LibTest/core/RegExp/firstMatch_A01_t01: RuntimeError # Co19 issue 742 Co -> ...
5 years, 10 months ago (2015-01-30 12:48:01 UTC) #1
zerny-google
https://codereview.chromium.org/893563002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/893563002/diff/1/tests/co19/co19-co19.status#newcode55 tests/co19/co19-co19.status:55: LibTest/core/RegExp/firstMatch_A01_t01: RuntimeError # Co19 issue 742 On 2015/01/30 12:48:01, ...
5 years, 10 months ago (2015-01-30 12:49:26 UTC) #2
zerny-google
5 years, 10 months ago (2015-01-30 12:50:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698