Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 893193004: Propagate the stack trace of the inner-most throw when using async/await. (Closed)

Created:
5 years, 10 months ago by zerny-google
Modified:
5 years, 10 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, hausner
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Propagate the stack trace of the inner-most throw when using async/await. This patch does not provide a full async stack trace, it only ensures that the inner-most stack frame will be the point of the initial throw. BUG=http://dartbug.com/22009 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43463

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M runtime/lib/core_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 5 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +12 lines, -2 lines 1 comment Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
zerny-google
5 years, 10 months ago (2015-02-04 08:44:22 UTC) #1
Ivan Posva
LGTM -ip
5 years, 10 months ago (2015-02-04 10:29:42 UTC) #2
zerny-google
Committed patchset #1 (id:1) manually as 43463 (presubmit successful).
5 years, 10 months ago (2015-02-04 11:54:34 UTC) #3
hausner
DBC https://codereview.chromium.org/893193004/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/893193004/diff/1/runtime/vm/parser.cc#newcode3074 runtime/vm/parser.cc:3074: // * A continuation error. Comment is now ...
5 years, 10 months ago (2015-02-04 16:47:33 UTC) #5
hausner
Btw, I can take care of updating the comments with my sync* check-in.
5 years, 10 months ago (2015-02-04 16:50:56 UTC) #6
zerny-google
5 years, 10 months ago (2015-02-04 18:08:13 UTC) #7
Message was sent while issue was closed.
On 2015/02/04 16:50:56, hausner wrote:
> Btw, I can take care of updating the comments with my sync* check-in.

Thanks! That would be great. I don't have a VM cl in the queue atm.

Powered by Google App Engine
This is Rietveld 408576698