Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 892963002: Reduce timer stack overhead by getting immediate callback and run it, instead of calling through fu… (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reduce timer stack overhead by getting immediate callback and run it, instead of calling through function. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M runtime/lib/isolate_patch.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/lib/timer_impl.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-02-02 12:32:21 UTC) #2
Ivan Posva
LGTM -ip
5 years, 10 months ago (2015-02-02 15:35:47 UTC) #3
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-13 12:35:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698