Issue 892913003: Rename the get* methods in preparation for removing them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 892913003: Rename the get* methods in preparation for removing them. (Closed)

Created:
5 years, 10 months ago by turnidge

Modified:
5 years, 10 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Rename the get* methods in preparation for removing them. Add proper caching to getObject, etc. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43431

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -56 lines)			Patch
M	runtime/observatory/bin/shell.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/observatory/lib/service_common.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/lib/src/app/page.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/inbound_reference.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/lib/src/elements/isolate_view.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 2	16 chunks	+40 lines, -26 lines	0 comments	Download
M	runtime/observatory/test/classes_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/test/code_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/observatory/test/echo_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/observatory/test/functions_test.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	runtime/observatory/test/metrics_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/observatory/test/test_helper.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/test/type_arguments_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/test/vm_metrics_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2	2 chunks	+12 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

turnidge

5 years, 10 months ago (2015-02-03 21:47:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 43431 (presubmit successful).