Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891743002: Add support for super aliases to new emitter. (Closed)

Created:
5 years, 10 months ago by herhut
Modified:
5 years, 10 months ago
Reviewers:
floitsch, zarah
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for super aliases to new emitter. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43439

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Patch Set 3 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
herhut
WIP
5 years, 10 months ago (2015-01-30 13:52:15 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/891743002/diff/1/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/891743002/diff/1/pkg/compiler/lib/src/js_emitter/model.dart#newcode362 pkg/compiler/lib/src/js_emitter/model.dart:362: final String superAlias; Explain what this is, and ...
5 years, 10 months ago (2015-01-30 18:31:05 UTC) #3
herhut
5 years, 10 months ago (2015-02-03 22:08:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698