pkg/args: updated args dependency on collection_helpers to >= 0.9.1

pkg/args: updated args dependency on collection_helpers to >= 0.9.1

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30924

[kevmoo-old, 2013-11-26 20:49:54]

Important to track these changes from now on

[Bob Nystrom, 2013-11-26 21:52:45]

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode2
pkg/args/pubspec.yaml:2: version: 0.9.0+1-dev
Instead of bumping this now, I think we should just bump it before publishing.
Otherwise, it isn't clear when it has been bumped and when it needs it.

(Or are you planning to publish this soon?)

Also, why is this +1-dev?

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode13
pkg/args/pubspec.yaml:13: collection_helpers: '>=0.9.1 <0.10.0'
Does this actually require a change from collection_helpers 0.9.1?

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode15
pkg/args/pubspec.yaml:15: unittest: '>=0.9.0 <0.10.0'
You can leave the SDK constraint in.

[kevmoo-old, 2013-11-26 22:03:20]

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode2
pkg/args/pubspec.yaml:2: version: 0.9.0+1-dev
On 2013/11/26 21:52:45, Bob Nystrom wrote:
> Instead of bumping this now, I think we should just bump it before publishing.
> Otherwise, it isn't clear when it has been bumped and when it needs it.
> 
> (Or are you planning to publish this soon?)
> 
> Also, why is this +1-dev?

I've seen -dev used in a few other libs. It implies that the version is
"aspirational". Remove -dev when published.

Perhaps it'd be good for pkg folks to talk about the model here.

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode13
pkg/args/pubspec.yaml:13: collection_helpers: '>=0.9.1 <0.10.0'
On 2013/11/26 21:52:45, Bob Nystrom wrote:
> Does this actually require a change from collection_helpers 0.9.1?

Yup. This is catching up with
https://code.google.com/p/dart/source/detail?r=30402

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode15
pkg/args/pubspec.yaml:15: unittest: '>=0.9.0 <0.10.0'
On 2013/11/26 21:52:45, Bob Nystrom wrote:
> You can leave the SDK constraint in.

SDK constraint is still there, just bumped up a bit.

Left in Editor formatting and order -- closest thing we have to a canonical
representation of a pubspec file.

[kevmoo-old, 2013-11-26 22:05:01]

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode2
pkg/args/pubspec.yaml:2: version: 0.9.0+1-dev
On 2013/11/26 22:03:21, kevmoo wrote:
> On 2013/11/26 21:52:45, Bob Nystrom wrote:
> > Instead of bumping this now, I think we should just bump it before
publishing.
> > Otherwise, it isn't clear when it has been bumped and when it needs it.
> > 
> > (Or are you planning to publish this soon?)
> > 
> > Also, why is this +1-dev?
> 
> I've seen -dev used in a few other libs. It implies that the version is
> "aspirational". Remove -dev when published.
> 
> Perhaps it'd be good for pkg folks to talk about the model here.

To be super clear:

+1: flags that this is not even a bug release fix. No code change since last
release, just a pubsec delta.

-dev: flag that the version (0.9.0+1) is pre-release.

[kevmoo-old, 2013-12-02 16:22:45]

Ping?

[Bob Nystrom, 2013-12-03 18:28:48]

Are you planning to publish this after this patch goes in?

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode2
pkg/args/pubspec.yaml:2: version: 0.9.0+1-dev
On 2013/11/26 22:05:01, kevmoo wrote:
> On 2013/11/26 22:03:21, kevmoo wrote:
> > On 2013/11/26 21:52:45, Bob Nystrom wrote:
> > > Instead of bumping this now, I think we should just bump it before
> publishing.
> > > Otherwise, it isn't clear when it has been bumped and when it needs it.
> > > 
> > > (Or are you planning to publish this soon?)
> > > 
> > > Also, why is this +1-dev?
> > 
> > I've seen -dev used in a few other libs. It implies that the version is
> > "aspirational". Remove -dev when published.
> > 
> > Perhaps it'd be good for pkg folks to talk about the model here.
> 
> To be super clear:
> 
> +1: flags that this is not even a bug release fix. No code change since last
> release, just a pubsec delta.
> 
> -dev: flag that the version (0.9.0+1) is pre-release.

Hmm, I don't have a well-defined proposal yet for how we should track versions
here, but I'm not a fan of bumping versions eagerly.

The nice thing about sticking with the previous version until you're ready to
release is that it prevents you from accidentally publishing it since that
version is already up there.

https://codereview.chromium.org/89173002/diff/1/pkg/args/pubspec.yaml#newcode15
pkg/args/pubspec.yaml:15: unittest: '>=0.9.0 <0.10.0'
On 2013/11/26 22:03:21, kevmoo wrote:
> On 2013/11/26 21:52:45, Bob Nystrom wrote:
> > You can leave the SDK constraint in.
> 
> SDK constraint is still there, just bumped up a bit.
> 
> Left in Editor formatting and order -- closest thing we have to a canonical
> representation of a pubspec file.

Ah, didn't notice that. OK.

[kevmoo-old, 2013-12-05 21:51:06]

Nathan eliminated the issue by bumping the version to 0.10.0 in
https://code.google.com/p/dart/source/detail?r=30678

To confirm: this simple updates the lowest dependency to the version of
collection_helpers with the required unmodifiable classes

PTAAL

[Bob Nystrom, 2013-12-05 23:30:13]

lgtm

[kevmoo-old, 2013-12-05 23:39:34]

Committed patchset #2 manually as r30924 (presubmit successful).