Issue 891583002: Add type annotations to some dart:html closures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 891583002: Add type annotations to some dart:html closures (Closed)

Created:
5 years, 10 months ago by sra1

Modified:
5 years, 10 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add type annotations to some dart:html closures This helps code quality when the types can be trusted or verified. R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=43349

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -32 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		8 chunks	+18 lines, -10 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		9 chunks	+20 lines, -12 lines	0 comments	Download
M	sdk/lib/html/html_common/css_class_set.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/src/CssClassSet.dart	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

lgtm https://codereview.chromium.org/891583002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/891583002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode10118 sdk/lib/html/dart2js/html_dart2js.dart:10118: + // times. Maybe Remove " Maybe" or ...

5 years, 10 months ago (2015-01-30 23:02:47 UTC) #3

sra1

5 years, 10 months ago (2015-01-30 23:08:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43349 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 891583002: Add type annotations to some dart:html closures (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages