Issue 891473006: Fix for the server version test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 891473006: Fix for the server version test. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for the server version test. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43561

Patch Set 2 : Use constant instead of literal #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analysis_server/test/domain_server_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/891473006/diff/1/pkg/analysis_server/test/domain_server_test.dart File pkg/analysis_server/test/domain_server_test.dart (right): https://codereview.chromium.org/891473006/diff/1/pkg/analysis_server/test/domain_server_test.dart#newcode43 pkg/analysis_server/test/domain_server_test.dart:43: VERSION: '1.1.0' I think this should use the ...

5 years, 10 months ago (2015-02-06 19:10:08 UTC) #2

scheglov

5 years, 10 months ago (2015-02-06 19:11:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43561 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 891473006: Fix for the server version test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use constant instead of literal #

Messages