Issue 891343006: Always use isolate creation callback passed to Dart_Initialize for service isolate startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 891343006: Always use isolate creation callback passed to Dart_Initialize for service isolate startup (Closed)

Created:
5 years, 10 months ago by Cutch

Modified:
5 years, 10 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Always use isolate creation callback passed to Dart_Initialize for service isolate startup BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=43358

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	runtime/vm/service.h	View		3 chunks	+6 lines, -1 line	0 comments	Download
	M	runtime/vm/service.cc	View	1	4 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

turnidge

lgtm w/c https://codereview.chromium.org/891343006/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/891343006/diff/1/runtime/vm/service.cc#newcode808 runtime/vm/service.cc:808: // that change this after Dart_Initiliaze returns. ...

5 years, 10 months ago (2015-02-02 19:33:16 UTC) #3

Cutch

Committed patchset #2 (id:20001) manually as 43358 (presubmit successful).

5 years, 10 months ago (2015-02-02 19:36:04 UTC) #4

Cutch

5 years, 10 months ago (2015-02-02 19:36:04 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/891343006/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/891343006/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:808: // that change this after Dart_Initiliaze returns.
On 2015/02/02 19:33:16, turnidge wrote:
> Typo: Dart_Initialize

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 891343006: Always use isolate creation callback passed to Dart_Initialize for service isolate startup (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages