Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 891293003: Store zone in microtask entry. (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Store zone in microtask entry. Avoids an extra stack-trace for doing zone.bindCallback (which is not overridable anyway). Only optimizes cases where a new zone overrides neither scheduleMicrotask nor errorHandler. Committed: https://code.google.com/p/dart/source/detail?r=45125

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix type assertion. Don't store zone if using zone.bind. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M sdk/lib/async/schedule_microtask.dart View 1 5 chunks +29 lines, -14 lines 0 comments Download
M sdk/lib/async/zone.dart View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lasse Reichstein Nielsen
Reduces stack height in simple cases.
5 years, 10 months ago (2015-02-02 12:32:39 UTC) #2
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-02-02 12:33:07 UTC) #4
Ivan Posva
LGTMwC -ip https://codereview.chromium.org/891293003/diff/1/sdk/lib/async/schedule_microtask.dart File sdk/lib/async/schedule_microtask.dart (right): https://codereview.chromium.org/891293003/diff/1/sdk/lib/async/schedule_microtask.dart#newcode71 sdk/lib/async/schedule_microtask.dart:71: // same Timer callback. I am not ...
5 years, 10 months ago (2015-02-02 16:06:47 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/891293003/diff/1/sdk/lib/async/schedule_microtask.dart File sdk/lib/async/schedule_microtask.dart (right): https://codereview.chromium.org/891293003/diff/1/sdk/lib/async/schedule_microtask.dart#newcode71 sdk/lib/async/schedule_microtask.dart:71: // same Timer callback. I think the timer is ...
5 years, 10 months ago (2015-02-23 08:01:39 UTC) #6
Lasse Reichstein Nielsen
https://codereview.chromium.org/891293003/diff/1/sdk/lib/async/schedule_microtask.dart File sdk/lib/async/schedule_microtask.dart (right): https://codereview.chromium.org/891293003/diff/1/sdk/lib/async/schedule_microtask.dart#newcode71 sdk/lib/async/schedule_microtask.dart:71: // same Timer callback. I think the timer is ...
5 years, 10 months ago (2015-02-23 08:01:40 UTC) #7
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-14 07:37:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698