Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891053004: Make Dart_Invoke work for private static functions (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Dart_Invoke work for private static functions Our API documentation states that Dart_Invoke will invoke private functions. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=43375

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 3 chunks +28 lines, -2 lines 0 comments Download
M runtime/vm/resolver.h View 1 chunk +9 lines, -1 line 0 comments Download
M runtime/vm/resolver.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 10 months ago (2015-02-03 00:14:42 UTC) #2
turnidge
lgtm w/ c https://codereview.chromium.org/891053004/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/891053004/diff/1/runtime/vm/dart_api_impl_test.cc#newcode5144 runtime/vm/dart_api_impl_test.cc:5144: name = PrivateLibName(lib, "_topMethod"); Maybe you ...
5 years, 10 months ago (2015-02-03 00:21:41 UTC) #3
Cutch
https://codereview.chromium.org/891053004/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/891053004/diff/1/runtime/vm/dart_api_impl_test.cc#newcode5144 runtime/vm/dart_api_impl_test.cc:5144: name = PrivateLibName(lib, "_topMethod"); On 2015/02/03 00:21:41, turnidge wrote: ...
5 years, 10 months ago (2015-02-03 00:26:31 UTC) #4
Cutch
5 years, 10 months ago (2015-02-03 00:37:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698