Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890573002: VM: Simplify dispatcher code for closure calls. (Closed)

Created:
5 years, 10 months ago by Florian Schneider
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Simplify dispatcher code for closure calls. The getter call to ".call" can be avoided for Function objects, since it just returns the receiver there. This makes the unoptimized code smaller. Optimized code will only be affected if the getter call was not inlined before. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M runtime/vm/parser.cc View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 10 months ago (2015-01-29 14:36:46 UTC) #2
Vyacheslav Egorov (Google)
lgtm
5 years, 10 months ago (2015-01-29 14:38:44 UTC) #3
Vyacheslav Egorov (Google)
lgtm lgtm
5 years, 10 months ago (2015-01-29 14:38:44 UTC) #4
Florian Schneider
5 years, 10 months ago (2015-01-29 14:50:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r43287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698