Issue 88983004: Support Bigint parameters in Int32x4 constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88983004: Support Bigint parameters in Int32x4 constructor (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support Bigint parameters in Int32x4 constructor https://code.google.com/p/dart/issues/detail?id=15130 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30686

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -4 lines)			Patch
M	runtime/lib/simd128.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/bigint_operations.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/bigint_operations.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	4 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	4 chunks	+21 lines, -0 lines	0 comments	Download
A	tests/lib/typed_data/int32x4_bigint_test.dart	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comments https://codereview.chromium.org/88983004/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/88983004/diff/20001/runtime/vm/object.h#newcode4479 runtime/vm/object.h:4479: virtual int32_t AsTruncatedUint32Value() const; s/int32_t/uint32_t/ Here ...

7 years ago (2013-11-26 23:39:15 UTC) #2

Cutch

Added a test also. https://codereview.chromium.org/88983004/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/88983004/diff/20001/runtime/vm/object.h#newcode4479 runtime/vm/object.h:4479: virtual int32_t AsTruncatedUint32Value() const; On ...

7 years ago (2013-11-26 23:44:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r30686 (presubmit successful).

Expand Messages | Collapse Messages

Issue 88983004: Support Bigint parameters in Int32x4 constructor (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages