Issue 889743002: pkg/analyzer: Cleanup added optional packages root argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 889743002: pkg/analyzer: Cleanup added optional packages root argument (Closed)

Created:
5 years, 10 months ago by kevmoo

Modified:
5 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

pkg/analyzer: Cleanup added optional packages root argument ...and other cleanup R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43407

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -14 lines)			Patch
	M	pkg/analyzer/example/resolver_driver.dart	View	1 2 3	2 chunks	+29 lines, -14 lines	0 comments	Download

Total messages: 6 (1 generated)

scheglov

There are no parser_driver.dart and scanner_driver.dart diffs.

5 years, 10 months ago (2015-02-03 16:18:59 UTC) #3

kevmoo

On 2015/02/03 16:18:59, scheglov wrote: > There are no parser_driver.dart and scanner_driver.dart diffs. PTAL

5 years, 10 months ago (2015-02-03 16:25:30 UTC) #4

kevmoo

5 years, 10 months ago (2015-02-03 16:28:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as 43407 (presubmit successful).