Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889643002: dart2js: emit metadata in new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: emit metadata in new emitter. The metadata currently doesn't yet contain all the information that is needed. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43320

Patch Set 1 #

Patch Set 2 : Rename metadata_emitter.dart -> metadata_collector.dart #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Metadata must be emitted after constants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
https://codereview.chromium.org/889643002/diff/40001/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/889643002/diff/40001/pkg/compiler/lib/src/js_emitter/model.dart#newcode44 pkg/compiler/lib/src/js_emitter/model.dart:44: /// References to classes or constants are wrapped into ...
5 years, 10 months ago (2015-01-29 17:06:31 UTC) #2
floitsch
https://codereview.chromium.org/889643002/diff/40001/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/889643002/diff/40001/pkg/compiler/lib/src/js_emitter/model.dart#newcode44 pkg/compiler/lib/src/js_emitter/model.dart:44: /// References to classes or constants are wrapped into ...
5 years, 10 months ago (2015-01-29 17:12:18 UTC) #3
zarah
LGTM
5 years, 10 months ago (2015-01-29 19:39:52 UTC) #4
floitsch
5 years, 10 months ago (2015-01-29 23:23:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 43320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698