Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 889583004: fix race condition when recording computeCache performance (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

fix race condition when recording computeCache performance and improve completion performance status page BUG=dartbug.com/22205 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 3 chunks +17 lines, -21 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 7 chunks +25 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 10 months ago (2015-01-29 16:54:02 UTC) #2
Paul Berry
lgtm
5 years, 10 months ago (2015-01-29 17:00:11 UTC) #3
danrubel
5 years, 10 months ago (2015-01-29 17:01:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698