Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889573005: dart2js: emit callstubs in new emitter and rename to stubs. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, herhut
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: emit callstubs in new emitter and rename to stubs. The rename is because we will use the same field for noSuchMethod stubs in the next step. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43378

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
zarah
5 years, 10 months ago (2015-02-02 15:35:37 UTC) #2
zarah
5 years, 10 months ago (2015-02-02 15:35:37 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/889573005/diff/1/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/889573005/diff/1/pkg/compiler/lib/src/js_emitter/model.dart#newcode208 pkg/compiler/lib/src/js_emitter/model.dart:208: final List<StubMethod> stubs; Give a description of what ...
5 years, 10 months ago (2015-02-02 15:40:23 UTC) #4
zarah
https://codereview.chromium.org/889573005/diff/1/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/889573005/diff/1/pkg/compiler/lib/src/js_emitter/model.dart#newcode208 pkg/compiler/lib/src/js_emitter/model.dart:208: final List<StubMethod> stubs; On 2015/02/02 15:40:23, floitsch wrote: > ...
5 years, 10 months ago (2015-02-02 16:14:47 UTC) #5
zarah
5 years, 10 months ago (2015-02-03 08:06:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698