Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889443002: Service isolate rework take 2 (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Service isolate rework take 2 Committed: https://code.google.com/p/dart/source/detail?r=43306

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1343 lines, -556 lines) Patch
M runtime/bin/bin.gypi View 7 chunks +125 lines, -3 lines 0 comments Download
M runtime/bin/builtin.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/builtin.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/builtin.dart View 1 2 3 4 12 chunks +227 lines, -143 lines 0 comments Download
A runtime/bin/builtin_common.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/dartutils.h View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 2 7 chunks +147 lines, -62 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +14 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 9 chunks +42 lines, -85 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/bin/resources_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/secure_socket_unsupported.cc View 1 chunk +10 lines, -0 lines 0 comments Download
D runtime/bin/vmservice.h View 1 chunk +0 lines, -17 lines 0 comments Download
A runtime/bin/vmservice/loader.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/resources.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/server.dart View 2 chunks +8 lines, -1 line 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 3 chunks +16 lines, -4 lines 0 comments Download
A runtime/bin/vmservice_dartium.h View 1 chunk +38 lines, -0 lines 0 comments Download
A runtime/bin/vmservice_dartium.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M runtime/bin/vmservice_impl.h View 3 chunks +21 lines, -7 lines 0 comments Download
M runtime/bin/vmservice_impl.cc View 8 chunks +83 lines, -57 lines 0 comments Download
M runtime/include/dart_api.h View 3 chunks +12 lines, -44 lines 0 comments Download
M runtime/lib/isolate.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/tools/gyp/runtime-configurations.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_table.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/dart.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 4 5 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/service.h View 6 chunks +23 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 10 chunks +245 lines, -82 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +8 lines, -6 lines 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 10 months ago (2015-01-28 23:14:19 UTC) #2
Cutch
On 2015/01/28 23:14:19, Cutch wrote: TBR
5 years, 10 months ago (2015-01-29 18:29:11 UTC) #3
Cutch
5 years, 10 months ago (2015-01-29 18:32:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as 43306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698