Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 888943004: Implement new "yield*" type checking rules in analyzer. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement new "yield*" type checking rules in analyzer. This updates analyzer to reflect the new static type checking rules for yield each added in r43420. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -31 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +25 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 2 chunks +22 lines, -0 lines 0 comments Download
M tests/language/async_await_syntax_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-03 22:30:08 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-03 22:57:39 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-03 23:13:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698