Issue 88853002: Call exit instead of returning from main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88853002: Call exit instead of returning from main (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Call exit instead of returning from main BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30672

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -44 lines)			Patch
	M	runtime/bin/main.cc	View	1 2	11 chunks	+34 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/88853002/diff/10001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/88853002/diff/10001/runtime/bin/main.cc#newcode692 runtime/bin/main.cc:692: static void Exit(int exit_code) { Seems like ...

7 years ago (2013-11-26 18:05:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r30672 (presubmit successful).

Expand Messages | Collapse Messages

Issue 88853002: Call exit instead of returning from main (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages