Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 88803002: Added debug timer to test.dart (Closed)

Created:
7 years ago by kustermann
Modified:
7 years ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added debug timer to test.dart We are seeing a lot of test.dart timeouts on our browser bots. This is an attempt to get more information on what is going on. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=30765

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
dart/tools/testing/dart/test_runner.dart View 1 3 chunks +60 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years ago (2013-11-26 17:25:08 UTC) #1
ricow1
lgtm, but I think we should extract this out, the constructor is already really big ...
7 years ago (2013-11-27 08:35:32 UTC) #2
kustermann
https://codereview.chromium.org/88803002/diff/1/dart/tools/testing/dart/test_runner.dart File dart/tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/88803002/diff/1/dart/tools/testing/dart/test_runner.dart#newcode2332 dart/tools/testing/dart/test_runner.dart:2332: void cancelDebugTimer() { On 2013/11/27 08:35:32, ricow1 wrote: > ...
7 years ago (2013-11-28 16:11:55 UTC) #3
kustermann
7 years ago (2013-11-28 16:20:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r30765 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698