Add simple Dart tasks

Add simple Dart tasks

R=paulberry@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43261

[Brian Wilkerson, 2015-01-28 16:57:50]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2015-01-28 16:57:51]

The first couple of Dart related tasks converted to the new task model.

[Paul Berry, 2015-01-28 18:25:53]

lgtm

https://codereview.chromium.org/887433002/diff/1/pkg/analyzer/lib/src/task/da...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/887433002/diff/1/pkg/analyzer/lib/src/task/da...
pkg/analyzer/lib/src/task/dart.dart:163: HashSet<Source> importedSources = new
HashSet<Source>();
If there is no explicit import of dart:core, should we include the implicit
import of it in importedSources?

https://codereview.chromium.org/887433002/diff/1/pkg/analyzer/lib/src/task/da...
pkg/analyzer/lib/src/task/dart.dart:300: if (source == null) {
This logic for handling source == null is repeated 3 times, despite the fact
that all 3 of these tasks use getRequiredSource() in their internalPerform()
method (so in the absence of a bug source will never be null).

Consider moving the "description" method to a common base class, and having it
do something slightly more generic, e.g.:

@override
String get description {
  Source source = target.source;
  String sourceName = target.source == null ? '<unknown source>' :
source.fullName;
  return '${descriptor.name} for source $sourceName';
}

[Brian Wilkerson, 2015-01-28 20:51:07]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2015-01-28 20:51:08]

PTAL

https://codereview.chromium.org/887433002/diff/1/pkg/analyzer/lib/src/task/da...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/887433002/diff/1/pkg/analyzer/lib/src/task/da...
pkg/analyzer/lib/src/task/dart.dart:163: HashSet<Source> importedSources = new
HashSet<Source>();
> If there is no explicit import of dart:core, should we include the implicit
> import of it in importedSources?

Possibly. At the moment this is done when we build the element model for the
library as a whole. I'll have to think about whether there's an advantage to
waiting or whether it would make more sense to move it earlier.

https://codereview.chromium.org/887433002/diff/1/pkg/analyzer/lib/src/task/da...
pkg/analyzer/lib/src/task/dart.dart:300: if (source == null) {
> This logic for handling source == null is repeated 3 times, despite the fact
> that all 3 of these tasks use getRequiredSource() in their internalPerform()
> method (so in the absence of a bug source will never be null).

I don't follow. internalPerform doesn't have to be called before description, so
we can't assume at this point that the target is valid. And, once we start
writing tasks for non-source targets, getRequiredSource won't necessarily be
called at all.

> Consider moving the "description" method to a common base class, and having it
> do something slightly more generic ...

It won't read as well, but it's probably a good idea. Done.

[scheglov, 2015-01-28 21:19:16]

LGTM

[Brian Wilkerson, 2015-01-28 21:56:53]

Committed patchset #2 (id:20001) manually as 43261 (presubmit successful).