Issue 886903003: dart2js: emit adapters in new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886903003: dart2js: emit adapters in new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch

Modified:
5 years, 10 months ago

Reviewers:
zarah, herhut

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

dart2js: emit adapters in new emitter. This is pretty incomplete, since it doesn't take tear-offs into account, but most adapters should work. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43347

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart	View	1	3 chunks	+26 lines, -5 lines	0 comments	Download

Total messages: 5 (1 generated)

floitsch

I haven't spend lots of efforts making the generation of the stub methods clean and ...

5 years, 10 months ago (2015-01-29 23:59:06 UTC) #2

zarah

LGTM, maybe update the link to the new cl that it now depends on?

5 years, 10 months ago (2015-01-30 14:21:15 UTC) #3

floitsch

On 2015/01/30 14:21:15, zarah wrote: > LGTM, > > maybe update the link to the ...

5 years, 10 months ago (2015-01-30 21:49:47 UTC) #4

floitsch

5 years, 10 months ago (2015-01-30 21:50:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 43347 (presubmit successful).