Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886773004: Supported versioned patching. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
floitsch, zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Supported versioned patching. BUG= R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43275

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -92 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +5 lines, -1 line 2 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 10 chunks +97 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/scanner/class_element_parser.dart View 9 chunks +21 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/annotations.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +8 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 5 chunks +80 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
5 years, 10 months ago (2015-01-29 11:35:34 UTC) #2
herhut
lgtm
5 years, 10 months ago (2015-01-29 11:56:33 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 43275 (presubmit successful).
5 years, 10 months ago (2015-01-29 12:08:35 UTC) #4
floitsch
DBC. (hit that line during a conflicting merge). https://codereview.chromium.org/886773004/diff/1/pkg/compiler/lib/src/js_backend/js_backend.dart File pkg/compiler/lib/src/js_backend/js_backend.dart (right): https://codereview.chromium.org/886773004/diff/1/pkg/compiler/lib/src/js_backend/js_backend.dart#newcode22 pkg/compiler/lib/src/js_backend/js_backend.dart:22: show ...
5 years, 10 months ago (2015-01-29 14:58:20 UTC) #6
Johnni Winther
5 years, 10 months ago (2015-01-30 08:42:19 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/886773004/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/js_backend.dart (right):

https://codereview.chromium.org/886773004/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/js_backend.dart:22: show Emitter,
On 2015/01/29 14:58:20, floitsch wrote:
> nit: we usually have "show" at the end of the line (see line 36).
> 
> Also a new line after the shows.

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698