Issue 886633003: Fix remaining uses of lookupConstructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886633003: Fix remaining uses of lookupConstructor. (Closed)

Created:
5 years, 10 months ago by herhut

Modified:
5 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, Kevin Millikin (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix remaining uses of lookupConstructor. BUG= TBR=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43277

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -19 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View	1 chunk	+2 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

herhut

Committed patchset #1 (id:1) manually as 43277 (presubmit successful).

5 years, 10 months ago (2015-01-29 12:25:02 UTC) #2

Johnni Winther

5 years, 10 months ago (2015-01-29 12:42:17 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/886633003/diff/1/tests/compiler/dart2js/resol...
File tests/compiler/dart2js/resolver_test.dart (right):

https://codereview.chromium.org/886633003/diff/1/tests/compiler/dart2js/resol...
tests/compiler/dart2js/resolver_test.dart:689: element =
classElement.lookupConstructor(constructor);
I think this should always be used since we are part of resolution here. The
else branch might be from when constructors didn't have their simple names.

Expand Messages | Collapse Messages