Issue 88553003: pkg/args: a bunch of test cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88553003: pkg/args: a bunch of test cleanup (Closed)

Created:
7 years ago by kevmoo-old

Modified:
7 years ago

Reviewers:
nweiz, Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/args: a bunch of test cleanup R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=30675

Patch Set 2 : nits #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -59 lines)			Patch
M	pkg/args/test/args_test.dart	View	1	2 chunks	+31 lines, -33 lines	0 comments	Download
M	pkg/args/test/command_test.dart	View	1	2 chunks	+2 lines, -9 lines	0 comments	Download
M	pkg/args/test/parse_all_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/args/test/parse_test.dart	View	1	2 chunks	+2 lines, -9 lines	0 comments	Download
M	pkg/args/test/usage_test.dart	View		2 chunks	+2 lines, -6 lines	0 comments	Download
A	pkg/args/test/utils.dart	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

I went in thinking I was going to fix something, then I decided it wasn't ...

7 years ago (2013-11-26 18:57:17 UTC) #1

Bob Nystrom

A few suggestions then LGTM. Thanks for doing this! :) https://codereview.chromium.org/88553003/diff/1/pkg/args/test/shared.dart File pkg/args/test/shared.dart (right): https://codereview.chromium.org/88553003/diff/1/pkg/args/test/shared.dart#newcode1 ...

7 years ago (2013-11-26 19:07:41 UTC) #2

kevmoo-old

7 years ago (2013-11-26 19:35:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30675 (presubmit successful).

Expand Messages | Collapse Messages

Issue 88553003: pkg/args: a bunch of test cleanup (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Messages