Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 885093002: dart2js: Fix types in new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Fix types in new emitter. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43319

Patch Set 1 #

Patch Set 2 : Fix indentation types and implements/extends. #

Patch Set 3 : Fix more types. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 2 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 10 months ago (2015-01-29 16:44:51 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-01-29 19:31:18 UTC) #3
floitsch
5 years, 10 months ago (2015-01-29 23:22:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698