Issue 88483002: Compute suggestions for failed type promotions.

Issue 88483002: Compute suggestions for failed type promotions. (Closed)

Created:
7 years ago by Johnni Winther

Modified:
7 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Compute suggestions for failed type promotions. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=30845

Patch Set 3 : Updated cf. comments. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+266 lines, -22 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1	2 chunks	+109 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2	2 chunks	+59 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 2	1 chunk	+48 lines, -11 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	1 2	4 chunks	+39 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/88483002/diff/20001/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/88483002/diff/20001/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode1677 sdk/lib/_internal/compiler/implementation/dart_types.dart:1677: class MoreSpecificSubtypeVisitor extends DartTypeVisitor<bool, DartType> { Add a ...

7 years ago (2013-12-04 07:39:18 UTC) #3

Johnni Winther

Committed patchset #3 manually as r30845 (presubmit successful).

7 years ago (2013-12-04 10:18:52 UTC) #4

Johnni Winther

7 years ago (2013-12-04 10:20:26 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/88483002/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/88483002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1677: class
MoreSpecificSubtypeVisitor extends DartTypeVisitor<bool, DartType> {
On 2013/12/04 07:39:18, karlklose wrote:
> Add a TODO: check for bounds and don't suggest malbounded ones.

Done.

https://codereview.chromium.org/88483002/diff/20001/tests/compiler/dart2js/ty...
File tests/compiler/dart2js/type_checker_test.dart (right):

https://codereview.chromium.org/88483002/diff/20001/tests/compiler/dart2js/ty...
tests/compiler/dart2js/type_checker_test.dart:1574: var x = d.f;
On 2013/12/04 07:39:18, karlklose wrote:
> Perhaps add a comment what we expect.

Done.

https://codereview.chromium.org/88483002/diff/20001/tests/compiler/dart2js/ty...
tests/compiler/dart2js/type_checker_test.dart:1577: hints:
[MessageKind.NOT_MORE_SPECIFIC_SUGGESTION],
On 2013/12/04 07:39:18, karlklose wrote:
> How about changing hints: to take a list that can include predicates like:
>   [(message) => message.kind == MessageKind.NOT_MORE_SPECIFIC_SUGGESTION &&
> message.text.contains('F<int, dynamic>')]
> ?

Done.

Expand Messages | Collapse Messages