Issue 22157. Cancel a pending refactoring request on receiving a new one.

Issue 22157. Cancel a pending refactoring request on receiving a new one.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157

Committed: https://code.google.com/p/dart/source/detail?r=43201

[Paul Berry, 2015-01-27 17:50:29]

lgtm

https://codereview.chromium.org/884453002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/884453002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:321: * Marks the current
request as cancelled and clean ups.
s/and clean ups/and cleans up/

https://codereview.chromium.org/884453002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:552: server.sendResponse(new
Response.refactoringRequestCancelled(request));
Why wait until here to send the response?  Why not send it immediately in the
cancel() method?

[Brian Wilkerson, 2015-01-27 17:59:06]

LGTM

[scheglov, 2015-01-27 19:23:55]

https://codereview.chromium.org/884453002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/884453002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:321: * Marks the current
request as cancelled and clean ups.
On 2015/01/27 17:50:28, Paul Berry wrote:
> s/and clean ups/and cleans up/

Done.

https://codereview.chromium.org/884453002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:552: server.sendResponse(new
Response.refactoringRequestCancelled(request));
On 2015/01/27 17:50:28, Paul Berry wrote:
> Why wait until here to send the response?  Why not send it immediately in the
> cancel() method?

Good idea!
Done.

[scheglov, 2015-01-27 19:24:28]

Committed patchset #2 (id:20001) manually as 43201 (presubmit successful).