Issue 88433002: Emit a compile-time error when using type literals in case-expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88433002: Emit a compile-time error when using type literals in case-expressions. (Closed)

Created:
7 years ago by karlklose

Modified:
7 years ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit a compile-time error when using type literals in case-expressions. BUG=dartbug.com/15295 R=johnniwinther@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=30707

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	2 chunks	+3 lines, -1 line	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/compiler/dart2js_extra/type_constant_switch_test.dart	View	1 chunk	+7 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/88433002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/88433002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode1511 sdk/lib/_internal/compiler/implementation/typechecker.dart:1511: if (cls == compiler.typeClass) return true; Add a ...

7 years ago (2013-11-26 14:53:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30707 (presubmit successful).

Expand Messages | Collapse Messages