Remove last uses of IterableMixinWorkaround from VM's typed data implementation.

Remove last uses of IterableMixinWorkaround from VM's typed data implementation.

The remaining methods that used it are duplicated. This results
in better (specialized) code for typed data lists because type
feedback does not get mixed. It also avoids the additional
indirection of calling a static method on IterableMixinWorkaround.

BUG=dartbug.com/13647

Committed: https://code.google.com/p/dart/source/detail?r=43379

[Florian Schneider, 2015-01-29 12:30:34]

fschneider@google.com changed reviewers:
+ iposva@google.com, srdjan@google.com

[Florian Schneider, 2015-01-29 12:30:35]

Last CL in the series of cleanups of IterableMixinWorkaround that I started last
december.

[Ivan Posva, 2015-01-29 15:03:18]

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:245: // to instances of _TypeListBase. Instead the
subclasses use number-type specific
Long line.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:260: for (int i = 0; i < len; i++) {
Any reason for this change? Generally we tend to use non-typed locals, but typed
parameters and return types.

[srdjan, 2015-01-29 17:29:40]

LGT< with comments and what iposva said.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:274: int i = 0;
Remove int i = 0;

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:322: dynamic result = null;
var result = null;

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:325: for (int i = 0; i < len; ++i) {
Why not going backward len - 1 ... 0 and return first found element?

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:326: dynamic element = this[i];
var element =

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:338: dynamic result = null;
var result =

[Florian Schneider, 2015-02-03 08:18:19]

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:245: // to instances of _TypeListBase. Instead the
subclasses use number-type specific
On 2015/01/29 15:03:18, Ivan Posva wrote:
> Long line.

Done.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:260: for (int i = 0; i < len; i++) {
On 2015/01/29 15:03:18, Ivan Posva wrote:
> Any reason for this change? Generally we tend to use non-typed locals, but
typed
> parameters and return types.

Done.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:274: int i = 0;
On 2015/01/29 17:29:40, srdjan wrote:
> Remove int i = 0;

Done.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:322: dynamic result = null;
On 2015/01/29 17:29:39, srdjan wrote:
> var result = null;

Done.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:325: for (int i = 0; i < len; ++i) {
On 2015/01/29 17:29:39, srdjan wrote:
> Why not going backward len - 1 ... 0 and return first found element? 

Done.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:326: dynamic element = this[i];
On 2015/01/29 17:29:40, srdjan wrote:
> var element =

Done.

https://codereview.chromium.org/883693004/diff/80001/runtime/lib/typed_data.d...
runtime/lib/typed_data.dart:338: dynamic result = null;
On 2015/01/29 17:29:40, srdjan wrote:
> var result =

Done.

[Florian Schneider, 2015-02-03 08:27:42]

Committed patchset #6 (id:100001) manually as r43379 (presubmit successful).