Issue 883333002: More perf. improvements on crypto. _wordToBytes return Uint8List, but addAll is not prepared to run…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 883333002: More perf. improvements on crypto. _wordToBytes return Uint8List, but addAll is not prepared to run… (Closed)

Created:
5 years, 10 months ago by srdjan

Modified:
5 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More perf. improvements on crypto. _wordToBytes return Uint8List, but addAll is not prepared to run optimzally with typed data so use more neutral List<int> as result. TODO: adapt addAll for faster operations on typed data as well. Committed: https://code.google.com/p/dart/source/detail?r=43309

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/crypto/lib/src/hash_utils.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

Committed patchset #1 (id:1) manually as r43309 (presubmit successful).

5 years, 10 months ago (2015-01-29 19:11:09 UTC) #3

Message was sent while issue was closed.

LGTM -ip

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages