Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 882713009: Make synchronous broadcast StreamController throw if adding event while adding event. (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make synchronous broadcast StreamController throw if adding event while adding event. It already throws if there is more than one listener, but this change also makes it throw if there is only one listener, for consistency. Also add SynchronousStreamController abstract class. It only contains documentation for synchronous stream controllers. BUG= http://dartbug.com/22240 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43946

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update version number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -14 lines) Patch
M pkg/async/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/async/test/stream_zip_zone_test.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M sdk/lib/async/broadcast_stream_controller.dart View 1 chunk +12 lines, -1 line 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 6 chunks +113 lines, -10 lines 0 comments Download
M tests/lib/async/stream_controller_test.dart View 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
Maybe a little long-winded.
5 years, 10 months ago (2015-02-03 13:38:27 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/882713009/diff/1/pkg/async/pubspec.yaml File pkg/async/pubspec.yaml (right): https://codereview.chromium.org/882713009/diff/1/pkg/async/pubspec.yaml#newcode2 pkg/async/pubspec.yaml:2: version: 1.0.1-dev not sure if you don't want ...
5 years, 10 months ago (2015-02-11 10:00:42 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/882713009/diff/1/pkg/async/pubspec.yaml File pkg/async/pubspec.yaml (right): https://codereview.chromium.org/882713009/diff/1/pkg/async/pubspec.yaml#newcode2 pkg/async/pubspec.yaml:2: version: 1.0.1-dev I'll go to 1.1. It's detectable - ...
5 years, 10 months ago (2015-02-23 10:22:11 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 43946 (presubmit successful).
5 years, 10 months ago (2015-02-23 10:37:09 UTC) #6
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-02-23 10:38:49 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/882713009/diff/1/pkg/async/pubspec.yaml
File pkg/async/pubspec.yaml (right):

https://codereview.chromium.org/882713009/diff/1/pkg/async/pubspec.yaml#newcode2
pkg/async/pubspec.yaml:2: version: 1.0.1-dev
Hmm, that was unnecessary (but now it's done). The only change to the package
was in a test, which is not really a user visible change.

Powered by Google App Engine
This is Rietveld 408576698