Issue 882643004: Spec changes for issue 22254

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882643004: Spec changes for issue 22254 (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson

Modified:
5 years, 10 months ago

Reviewers:
Paul Berry, keertip

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -12 lines)			Patch
	M	pkg/analysis_server/tool/spec/spec_input.html	View		4 chunks	+25 lines, -12 lines	0 comments	Download

Total messages: 5 (1 generated)

Brian Wilkerson

I haven't run the generator; just wanted to know whether this looks like a reasonable ...

5 years, 10 months ago (2015-02-03 18:35:25 UTC) #2

Paul Berry

Sgtm. However, I think it's a lot less critical than many of the other bugs ...

5 years, 10 months ago (2015-02-03 18:51:05 UTC) #3

keertip

looks good. If this is something that does not require a lot of time to ...

5 years, 10 months ago (2015-02-03 18:58:25 UTC) #4

Brian Wilkerson

5 years, 10 months ago (2015-02-06 19:35:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43565 (presubmit successful).