Issue 882323004: VM: Share closure-call dispatchers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882323004: VM: Share closure-call dispatchers. (Closed)

Created:
5 years, 10 months ago by Florian Schneider

Modified:
5 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Share closure-call dispatchers. Instead of caching these in each signature class, cache them in the common super-class of all closures (_FunctionImpl) This avoid unecessary polymorphism when invoking. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43336

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -41 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/parser_test.cc	View	17 chunks	+39 lines, -37 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

https://codereview.chromium.org/882323004/diff/1/runtime/vm/parser_test.cc File runtime/vm/parser_test.cc (right): https://codereview.chromium.org/882323004/diff/1/runtime/vm/parser_test.cc#newcode274 runtime/vm/parser_test.cc:274: " 0 StackVar scope=1 begin=0 end=4 name=this\n" This change ...

5 years, 10 months ago (2015-01-29 17:27:21 UTC) #2

Florian Schneider

5 years, 10 months ago (2015-01-30 13:06:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r43336 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages