Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882273002: tests for earlier CL (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

tests for earlier CL BUG=dartbug.com/21768 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43295

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge and address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -3 lines) Patch
A pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 1 chunk +107 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 2 chunks +31 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 10 months ago (2015-01-28 22:31:25 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/882273002/diff/1/pkg/analysis_server/test/services/completion/completion_target_test.dart File pkg/analysis_server/test/services/completion/completion_target_test.dart (right): https://codereview.chromium.org/882273002/diff/1/pkg/analysis_server/test/services/completion/completion_target_test.dart#newcode26 pkg/analysis_server/test/services/completion/completion_target_test.dart:26: expect(completionOffset, isNull, reason: 'Call addTestUnit exactly once'); I ...
5 years, 10 months ago (2015-01-29 16:39:42 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as 43295 (presubmit successful).
5 years, 10 months ago (2015-01-29 16:50:30 UTC) #4
danrubel
5 years, 10 months ago (2015-01-29 16:54:50 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/882273002/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/completion/completion_target_test.dart
(right):

https://codereview.chromium.org/882273002/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/completion/completion_target_test.dart:26:
expect(completionOffset, isNull, reason: 'Call addTestUnit exactly once');
On 2015/01/29 16:39:42, Paul Berry wrote:
> I think you mean "Call addTestSource exactly once"

Yes. Fixed.

Powered by Google App Engine
This is Rietveld 408576698