Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 882233004: Async/await/yield[*] support for dart_fmt (Closed)

Created:
5 years, 10 months ago by pquitslund
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -10 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 chunk +7 lines, -9 lines 0 comments Download
M pkg/analyzer/test/services/data/stmt_tests.data View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pquitslund
I harvested some of the shared tests from Paul's recent CL... If you see any ...
5 years, 10 months ago (2015-02-05 20:40:50 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-05 20:44:00 UTC) #3
Paul Berry
lgtm https://codereview.chromium.org/882233004/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart File pkg/analyzer/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/882233004/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart#newcode510 pkg/analyzer/lib/src/services/formatter_impl.dart:510: // async[*] The keyword could also be "sync" ...
5 years, 10 months ago (2015-02-05 20:49:02 UTC) #4
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-05 20:57:30 UTC) #5
pquitslund
Thanks! https://codereview.chromium.org/882233004/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart File pkg/analyzer/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/882233004/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart#newcode510 pkg/analyzer/lib/src/services/formatter_impl.dart:510: // async[*] On 2015/02/05 20:49:02, Paul Berry wrote: ...
5 years, 10 months ago (2015-02-05 21:20:12 UTC) #7
pquitslund
5 years, 10 months ago (2015-02-05 22:37:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r43529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698