Issue 882203002: Fix for two semantic highlighting problems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882203002: Fix for two semantic highlighting problems. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for two semantic highlighting problems. 1. We need to dispose the existing semantic highlighting manager before setting a new input. So, we would not apply old highlighting to the new file. 2. We need to clear "input" fields to correctly determine full file path. R=danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43254

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java	View		3 chunks	+4 lines, -1 line	0 comments	Download
	M	pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 10 months ago (2015-01-28 19:55:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43254 (presubmit successful).

Expand Messages | Collapse Messages