Add synthetic type variables to unnamed mixin applications.

Add synthetic type variables to unnamed mixin applications.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30892

[karlklose, 2013-11-28 15:04:15]

LGTM, but do we have tests for the substitution, i.e., where we fix type
arguments?

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3827:
supertype = applyMixin(supertype, checkMixinType(link.head), link.head);
Long line.

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3923:
MixinApplicationElementX mixinApplication = new MixinApplicationElementX(
Do you need the implementation (X) class here?

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3958: // the
returning type (which should be the type actually extended).
'returning type' -> 'returned type'?

[ahe, 2013-11-28 15:28:25]

DBC

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:2265:
assert(invariant(this, named != null,
I'd really prefer if we didn't add redundant assertions. This will lead to a
null pointer error on line 2268, so the extra assertion doesn't add value.

[Johnni Winther, 2013-12-03 15:57:37]

@karlklose: PTAL at the test.

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:2265:
assert(invariant(this, named != null,
On 2013/11/28 15:28:26, ahe wrote:
> I'd really prefer if we didn't add redundant assertions. This will lead to a
> null pointer error on line 2268, so the extra assertion doesn't add value.

Done.

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3827:
supertype = applyMixin(supertype, checkMixinType(link.head), link.head);
On 2013/11/28 15:04:16, karlklose wrote:
> Long line.

Done.

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3923:
MixinApplicationElementX mixinApplication = new MixinApplicationElementX(
On 2013/11/28 15:04:16, karlklose wrote:
> Do you need the implementation (X) class here?

Needed to call computeThisAndRawType.

https://codereview.chromium.org/88153003/diff/40001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3958: // the
returning type (which should be the type actually extended).
On 2013/11/28 15:04:16, karlklose wrote:
> 'returning type' -> 'returned type'?

Done.

[karlklose, 2013-12-05 11:54:16]

SLGTM.

https://codereview.chromium.org/88153003/diff/80001/tests/compiler/dart2js/mi...
File tests/compiler/dart2js/mixin_typevariable_test.dart (right):

https://codereview.chromium.org/88153003/diff/80001/tests/compiler/dart2js/mi...
tests/compiler/dart2js/mixin_typevariable_test.dart:77: class _ {}
Why not just call it 'I' or use 'int' in the tests below?

https://codereview.chromium.org/88153003/diff/80001/tests/compiler/dart2js/mi...
tests/compiler/dart2js/mixin_typevariable_test.dart:154:
testSupertypes(F1.superclass, {A: [_], B: [_, instantiate(B, [F1_superclass_T,
_])]});
Long line.

[Johnni Winther, 2013-12-05 13:02:24]

Committed patchset #5 manually as r30892 (presubmit successful).