Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 881403002: Fix for issue 22052 (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -60 lines) Patch
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +26 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +38 lines, -30 lines 0 comments Download
M tests/language/await_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
If this looks good, I'll add an issue for the failing case. Is there anyone ...
5 years, 10 months ago (2015-01-28 20:07:48 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-01-28 21:33:52 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 43292 (presubmit successful).
5 years, 10 months ago (2015-01-29 16:02:23 UTC) #4
Paul Berry
5 years, 10 months ago (2015-01-29 16:46:48 UTC) #5
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/881403002/diff/1/tests/language/language_anal...
File tests/language/language_analyzer2.status (right):

https://codereview.chromium.org/881403002/diff/1/tests/language/language_anal...
tests/language/language_analyzer2.status:6:
await_backwards_compatibility_test/await1: MissingCompileTimeError # Issue ??
Should we file an issue for this?

Powered by Google App Engine
This is Rietveld 408576698