Implemented more of the Isolate API

- Implement some more missing pieces of the Isolate API.
  Added:
    * addOnExitListener, removeOnExitListener
    * setErrorsFatal
    * addOnErrorListener, removeOnErrorListener

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44307

[Ivan Posva, 2015-03-06 22:50:36]

iposva@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-03-06 23:56:04]

lgtm

https://codereview.chromium.org/881373002/diff/20001/runtime/lib/isolate_patc...
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/881373002/diff/20001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:417: /* patch */ void addErrorListener(SendPort
port) {
maybe call the param responsePort to be consistent with the code for
addOnExitListener ....

https://codereview.chromium.org/881373002/diff/20001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:425: /* patch */ void
removeErrorListener(SendPort port) {
Ditto comment on responsePort

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:140: kAsEventAction = 2
can these be in two enum blocks seems confusing to have two names with the same
values.

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:266: Object& obj = Object::Handle(I, message.At(2));
const Object& obj = ...;

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:267: if (!obj.IsSendPort()) return true;
Did we change the C++ style here, we always used to have this be written as
if (!obj.IsSendPort()) {
  return true;
}

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:997: static const intptr_t kMaxListeners = kSmiMax /
(6*kWordSize);
spaces 6 * kWOrdSize

[Ivan Posva, 2015-03-07 01:04:34]

Committed patchset #2 (id:20001) manually as r44307 (presubmit successful).

[Ivan Posva, 2015-03-07 04:20:40]

https://codereview.chromium.org/881373002/diff/20001/runtime/lib/isolate_patc...
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/881373002/diff/20001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:417: /* patch */ void addErrorListener(SendPort
port) {
On 2015/03/06 23:56:04, siva wrote:
> maybe call the param responsePort to be consistent with the code for
> addOnExitListener ....

I went by the names in the Dart API documentation. They are responsePort for
addOnExitListener and port for addErrorListener. Note that the names of the
functions are also inconsistent: One has an On, the other doesn't. Leaving as
is.

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:140: kAsEventAction = 2
On 2015/03/06 23:56:04, siva wrote:
> can these be in two enum blocks seems confusing to have two names with the
same
> values.

Done.

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:266: Object& obj = Object::Handle(I, message.At(2));
On 2015/03/06 23:56:04, siva wrote:
> const Object& obj = ...;

Done.

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:267: if (!obj.IsSendPort()) return true;
On 2015/03/06 23:56:04, siva wrote:
> Did we change the C++ style here, we always used to have this be written as
> if (!obj.IsSendPort()) {
>   return true;
> }

There are 2628 places in the project that use the single line if-statement where
we are guaranteed not to continue below, because of a break in control flow.

https://codereview.chromium.org/881373002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:997: static const intptr_t kMaxListeners = kSmiMax /
(6*kWordSize);
On 2015/03/06 23:56:04, siva wrote:
> spaces 6 * kWOrdSize

Done.