Store the aliasName of a method in the model.

Store the aliasName of a method in the model.

BUG=
R=floitsch@google.com, zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43387

[herhut, 2015-01-29 15:12:03]

Patchset #1 (id:1) has been deleted

[zarah, 2015-01-29 15:15:12]

LGTM

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:423:
namer.getNameOfAliasedSuperMember(element) : null;
Personal taste: if it can't fit on one line I think it't more readable with '?'
and ':' above each other.

[floitsch, 2015-01-29 15:24:36]

LGTM.

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/model.dart:332: final String aliasName;
Add documentation what this is.
When does it happen?
What does the emitter need to do with it?

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:255: final
String superAlias = method is InstanceMethod ? method.aliasName
Remove the `final` if that makes it fit on one line.

These 'final's don't seem to add any value...

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:419: final bool needsStubs
= _methodNeedsStubs(element);
no need for final (here and other locals).

[herhut, 2015-02-03 10:20:17]

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/model.dart:332: final String aliasName;
On 2015/01/29 15:24:35, floitsch wrote:
> Add documentation what this is.
> When does it happen?
> What does the emitter need to do with it?

Done.

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:255: final
String superAlias = method is InstanceMethod ? method.aliasName
On 2015/01/29 15:24:35, floitsch wrote:
> Remove the `final` if that makes it fit on one line.
> 
> These 'final's don't seem to add any value...

Removed them all.

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:419: final bool needsStubs
= _methodNeedsStubs(element);
On 2015/01/29 15:24:36, floitsch wrote:
> no need for final (here and other locals).

Done.

https://codereview.chromium.org/881363006/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:423:
namer.getNameOfAliasedSuperMember(element) : null;
On 2015/01/29 15:15:11, zarah wrote:
> Personal taste: if it can't fit on one line I think it't more readable with
'?'
> and ':' above each other.

Done.

[herhut, 2015-02-03 10:31:03]

Committed patchset #3 (id:60001) manually as 43387 (presubmit successful).