Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880973005: Support async/await in dart2dart. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org, hausner, Paul Berry
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use language test in unittest. #

Total comments: 1

Patch Set 3 : Updated cf. comment + status for new_backend #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -306 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 2 chunks +17 lines, -5 lines 0 comments Download
D tests/compiler/dart2js/async_await_syntax.dart View 1 1 chunk +0 lines, -273 lines 0 comments Download
M tests/compiler/dart2js/async_await_syntax_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/async_await_syntax_test.dart View 1 2 5 chunks +9 lines, -6 lines 1 comment Download
M tests/language/language.status View 1 2 3 chunks +33 lines, -13 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Johnni Winther
5 years, 10 months ago (2015-02-02 14:13:11 UTC) #2
floitsch
Please CC someone from the analyzer and VM team. LGTM. https://codereview.chromium.org/880973005/diff/20001/tests/language/async_await_syntax_test.dart File tests/language/async_await_syntax_test.dart (right): https://codereview.chromium.org/880973005/diff/20001/tests/language/async_await_syntax_test.dart#newcode7 ...
5 years, 10 months ago (2015-02-02 14:19:09 UTC) #4
Johnni Winther
5 years, 10 months ago (2015-02-02 14:34:38 UTC) #5
Paul Berry
Language changes lgtm.
5 years, 10 months ago (2015-02-02 15:42:19 UTC) #7
hausner
VM change to support sync* is on its way. Test looks ok.
5 years, 10 months ago (2015-02-02 19:28:24 UTC) #9
hausner
DBC https://codereview.chromium.org/880973005/diff/40001/tests/language/async_await_syntax_test.dart File tests/language/async_await_syntax_test.dart (left): https://codereview.chromium.org/880973005/diff/40001/tests/language/async_await_syntax_test.dart#oldcode15 tests/language/async_await_syntax_test.dart:15: a03b() async * {} /// a03b: compile-time error ...
5 years, 10 months ago (2015-02-02 23:37:02 UTC) #10
Johnni Winther
5 years, 10 months ago (2015-02-03 08:32:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698