Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880923003: dart2js: store typeToInterceptorMap in the model. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: store typeToInterceptorMap in the model. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43239

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 4 chunks +14 lines, -8 lines 1 comment Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
https://codereview.chromium.org/880923003/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/880923003/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode113 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:113: 'staticNonFinals': emitStaticNonFinalFields(fragment.staticNonFinalFields), I have a fix for this in ...
5 years, 10 months ago (2015-01-27 13:13:06 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-01-28 10:24:03 UTC) #4
floitsch
5 years, 10 months ago (2015-01-28 13:11:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698