Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880773003: dart2js: support native classes in the new emitter. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: support native classes in the new emitter. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43457

Patch Set 1 #

Patch Set 2 : Rename blob to info. #

Total comments: 2

Patch Set 3 : Address comment. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -35 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 3 10 chunks +126 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
Depends on https://chromiumcodereview.appspot.com/869953002/
5 years, 11 months ago (2015-01-27 13:37:30 UTC) #2
zarah
LGTM https://codereview.chromium.org/880773003/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/880773003/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode503 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:503: if (#hasNotNativeClasses) { hasNoNativeClasses
5 years, 11 months ago (2015-01-28 10:54:40 UTC) #4
floitsch
https://codereview.chromium.org/880773003/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/880773003/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode503 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:503: if (#hasNotNativeClasses) { On 2015/01/28 10:54:40, zarah wrote: > ...
5 years, 10 months ago (2015-01-28 13:28:27 UTC) #5
floitsch
5 years, 10 months ago (2015-02-04 09:42:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 43457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698