Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 880713002: add LibraryIdentifier (Closed)

Created:
5 years, 11 months ago by jakemac
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/static-init.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : code review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -66 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
A + lib/src/initialize_tracker.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M lib/src/initializer.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M lib/src/mirror_loader.dart View 1 1 chunk +16 lines, -1 line 0 comments Download
M lib/transformer.dart View 1 2 chunks +23 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/bar.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/cycle_a.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/cycle_b.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/foo.dart View 1 chunk +1 line, -1 line 0 comments Download
D test/initialize_tracker.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M test/initializer_custom_filter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/initializer_test.dart View 1 2 chunks +8 lines, -4 lines 0 comments Download
M test/transformer_test.dart View 1 4 chunks +35 lines, -24 lines 0 comments Download
A test_package/README.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + test_package/lib/bar.dart View 1 1 chunk +3 lines, -6 lines 0 comments Download
A + test_package/lib/foo.dart View 1 1 chunk +4 lines, -6 lines 0 comments Download
A test_package/pubspec.yaml View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jakemac
This is to support @HtmlImport path normalization in both mirror and static modes
5 years, 11 months ago (2015-01-26 23:55:10 UTC) #2
jakemac
Note: An alternative to this would be to force absolute package urls for everything. This ...
5 years, 11 months ago (2015-01-27 17:42:27 UTC) #3
jakemac
On 2015/01/27 17:42:27, jakemac wrote: > Note: An alternative to this would be to force ...
5 years, 11 months ago (2015-01-27 17:47:55 UTC) #4
Siggi Cherem (dart-lang)
lgtm, just minor nits below https://codereview.chromium.org/880713002/diff/1/initialize_test_fixtures/.gitignore File initialize_test_fixtures/.gitignore (right): https://codereview.chromium.org/880713002/diff/1/initialize_test_fixtures/.gitignore#newcode1 initialize_test_fixtures/.gitignore:1: # Pub files. for ...
5 years, 11 months ago (2015-01-27 20:26:29 UTC) #5
jakemac
https://codereview.chromium.org/880713002/diff/1/initialize_test_fixtures/.gitignore File initialize_test_fixtures/.gitignore (right): https://codereview.chromium.org/880713002/diff/1/initialize_test_fixtures/.gitignore#newcode1 initialize_test_fixtures/.gitignore:1: # Pub files. On 2015/01/27 20:26:28, Siggi Cherem (dart-lang) ...
5 years, 10 months ago (2015-01-28 17:52:31 UTC) #6
jakemac
5 years, 10 months ago (2015-01-28 17:53:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
126674209b13b463555acaf1960998f7b8251dea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698