Issue 88063002: Don't report file-system move events on Mac OS, and use no-defer to avoid past events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88063002: Don't report file-system move events on Mac OS, and use no-defer to avoid past events. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
nweiz, Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't report file-system move events on Mac OS, and use no-defer to avoid past events. Mac OS does not have a proper way to report 'from' and 'to', thus making it impossible to reason the move direction, as other events may shuffle the order, events are received in. BUG=https://code.google.com/p/dart/issues/detail?id=14806,https://code.google.com/p/dart/issues/detail?id=14793,https://code.google.com/p/dart/issues/detail?id=14849 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30710

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
M	runtime/bin/file_system_watcher_macos.cc	View		5 chunks	+7 lines, -4 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/standalone/io/file_system_watcher_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #2 manually as r30710 (presubmit successful).

7 years ago (2013-11-27 11:48:22 UTC) #4

nweiz

7 years ago (2013-11-27 20:34:10 UTC) #5

Message was sent while issue was closed.

Not reporting move events at all is *much worse* than reporting them with
misleading information. If no event is reported at all, there's no way for my
wrapper code to figure out what's going on and report it to the user.

The only reason this CL didn't turn all the pkg/watcher tests red on mac os is
because they're marked flaky for an unrelated issue. This will also directly
affect all users of "pub serve" on mac OS. Please either revert this or find
another way to report these events ASAP.

Expand Messages | Collapse Messages