Tweaks for refactoring manager.

Tweaks for refactoring manager.

My forgotten changes for your review comments.

R=paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43194

[Paul Berry, 2015-01-26 23:32:39]

lgtm

https://codereview.chromium.org/880613004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/880613004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:371: return null;
Aw, man, I didn't realize you would have to do this to avoid a warning.  That's
a shame.

In fact, thinking about it more, I suspect this is due to an analyzer bug. 
IMHO, the following code should be warning and hint free:

  Future f() async {
    return;
  }  

For the same reason that this code is warning free:

  dynamic f() {
    return;
  }

I'll reread the spec and see if we are analyzing the code correctly or not, and
I'll follow up with a bug report.

[Paul Berry, 2015-01-26 23:57:08]

On 2015/01/26 23:32:39, Paul Berry wrote:
> lgtm
> 
>
https://codereview.chromium.org/880613004/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):
> 
>
https://codereview.chromium.org/880613004/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/edit/edit_domain.dart:371: return null;
> Aw, man, I didn't realize you would have to do this to avoid a warning. 
That's
> a shame.
> 
> In fact, thinking about it more, I suspect this is due to an analyzer bug. 
> IMHO, the following code should be warning and hint free:
> 
>   Future f() async {
>     return;
>   }  
> 
> For the same reason that this code is warning free:
> 
>   dynamic f() {
>     return;
>   }
> 
> I'll reread the spec and see if we are analyzing the code correctly or not,
and
> I'll follow up with a bug report.

After looking at the spec, I'm now fairly certain that this is due to an
analyzer bug.  I've filed dartbug.com/22160 to track it.

[scheglov, 2015-01-27 17:39:20]

Committed patchset #1 (id:1) manually as 43194 (presubmit successful).